This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Removes AccountsDataMeter from InvokeContext #34698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34698 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 824 824
Lines 222725 222730 +5
=======================================
+ Hits 182317 182350 +33
+ Misses 40408 40380 -28 |
brooksprumo
force-pushed
the
accounts-data-size/accounts-data-meter/invoke-context
branch
from
02e041c to
27094cd
Compare
brooksprumo
commented
Jan 10, 2024
| @@ -175,7 +175,7 @@ impl MessageProcessor { | |||
| .map_err(|err| TransactionError::InstructionError(instruction_index as u8, err))?; | |||
| } | |||
| Ok(ProcessedMessageInfo { | |||
| accounts_data_len_delta: invoke_context.get_accounts_data_meter().delta(), | |||
| accounts_data_len_delta: 0, // unused | |||
There was a problem hiding this comment.
This will be removed in a subsequent PR.
brooksprumo
commented
Jan 10, 2024
| @@ -187,7 +185,7 @@ impl<'a> InvokeContext<'a> { | |||
| feature_set: Arc<FeatureSet>, | |||
| blockhash: Hash, | |||
| lamports_per_signature: u64, | |||
| prev_accounts_data_len: u64, | |||
| _prev_accounts_data_len: u64, | |||
There was a problem hiding this comment.
This will be removed in a subsequent PR.
Lichtso
approved these changes
Jan 10, 2024
|
What about the |
That's the next PR! #34727 |
brooksprumo
deleted the
accounts-data-size/accounts-data-meter/invoke-context
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
InvokeContextcontains anAccountsDataMeter, but it is not used anymore.Summary of Changes
Removes AccountsDataMeter from InvokeContext