This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
use staked connection for bench-tps in net scripts #34767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillLykov
changed the title
KirillLykov
commented
Jan 12, 2024
| clientCommand="\ | ||
| solana-bench-tps \ | ||
| --duration 7500 \ | ||
| --sustained \ | ||
| --threads $threadCount \ | ||
| $benchTpsExtraArgs \ | ||
| --read-client-keys ./client-accounts.yml \ | ||
| --url "http://$entrypointIp:8899" \ |
There was a problem hiding this comment.
In case if we use staked connection, we need to specify rpc address even if ThinClient is employed. This address is used to create RpcClient to check stake of the specified address and later another RpcClient is created. So I believe that there is no harm in specifying it always
KirillLykov
force-pushed
the
klykov/net-bench-tps-client-id
branch
from
bdc6793 to
c9afb39
Compare
KirillLykov
force-pushed
the
klykov/net-bench-tps-client-id
branch
from
c9afb39 to
0411016
Compare
|
A side note, I tried TpuClient and ThinClient and the former outperforms the later always. Another observation is that TPS is very volatile now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After adding throttling to streamer bench-tps shows ~50tps. To fix this we use staked connection.
The same as #34749
Summary of Changes