Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Removes fs-err dependency #34911

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

brooksprumo
Copy link
Contributor

Problem

We're trying to remove the fs-err crate. For more information, please refer to #34838.

Now there are no more uses of fs-err, so the dependency can be fully removed.

Summary of Changes

Remove the dependency

Fixes: #34885

@brooksprumo brooksprumo self-assigned this Jan 23, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 23, 2024 20:15
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (8ff511e) 81.6% compared to head (b807b65) 81.6%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34911     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         827      827             
  Lines      223884   223846     -38     
=========================================
- Hits       182841   182743     -98     
- Misses      41043    41103     +60     

@brooksprumo brooksprumo requested a review from t-nelson January 23, 2024 21:06
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah! :shipit:

@brooksprumo brooksprumo merged commit 3303c25 into solana-labs:master Jan 23, 2024
46 checks passed
@brooksprumo brooksprumo deleted the errors/remove-fs-err branch January 23, 2024 22:25
@brooksprumo
Copy link
Contributor Author

Now I need a v1.18 label to do the backport 😊

CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this pull request Jan 24, 2024
@brooksprumo brooksprumo added the v1.18 PRs that should be backported to v1.18 label Jan 24, 2024
Copy link
Contributor

mergify bot commented Jan 24, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Jan 24, 2024
(cherry picked from commit 3303c25)
brooksprumo added a commit that referenced this pull request Jan 26, 2024
Removes fs-err dependency (#34911)

(cherry picked from commit 3303c25)

Co-authored-by: Brooks <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v1.18 PRs that should be backported to v1.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on fs-err crate
2 participants