-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Removes fs-err dependency #34911
Removes fs-err dependency #34911
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34911 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 827 827
Lines 223884 223846 -38
=========================================
- Hits 182841 182743 -98
- Misses 41043 41103 +60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hell yeah!
Now I need a v1.18 label to do the backport 😊 |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 3303c25)
Removes fs-err dependency (#34911) (cherry picked from commit 3303c25) Co-authored-by: Brooks <[email protected]>
Problem
We're trying to remove the
fs-err
crate. For more information, please refer to #34838.Now there are no more uses of
fs-err
, so the dependency can be fully removed.Summary of Changes
Remove the dependency
Fixes: #34885