This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* quick fix for really big genesis * longer term fix for possible parallel verification over multiple Blobs/Entries
fixes #issue #446 |
garious
reviewed
Jun 26, 2018
src/ledger.rs
Outdated
@@ -90,7 +91,7 @@ pub fn next_entries_mut( | |||
let mut entries = Vec::with_capacity(transactions.len() / chunk_len + 1); | |||
|
|||
for chunk in transactions.chunks(chunk_len) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, I'm confused why this is transactions
and not transactions[chunk_len..]
.
This looks good to me, but definitely needs tests. And we need to document somewhere in ledger.rs that clients should not attempt to use a |
058fda2
to
b0df924
Compare
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
) Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.11.5 to 7.11.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.11.6/packages/babel-cli) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Apr 1, 2024
* [TieredStorage] enum-based AccountsFileProvider * derive traits * remove refs --------- Co-authored-by: jeff washington <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blobs/Entries
Fixes #446