Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

add entry.has_more #457

Merged
merged 4 commits into from
Jun 26, 2018
Merged

Conversation

rob-solana
Copy link
Contributor

@rob-solana rob-solana commented Jun 26, 2018

  • quick fix for really big genesis
  • longer term fix for possible parallel verification over multiple
    Blobs/Entries

Fixes #446

 * quick fix for really big genesis
 * longer term fix for possible parallel verification over multiple
      Blobs/Entries
@rob-solana rob-solana added the work in progress This isn't quite right yet label Jun 26, 2018
@rob-solana rob-solana requested a review from garious June 26, 2018 06:31
@rob-solana
Copy link
Contributor Author

fixes #issue #446

src/ledger.rs Outdated
@@ -90,7 +91,7 @@ pub fn next_entries_mut(
let mut entries = Vec::with_capacity(transactions.len() / chunk_len + 1);

for chunk in transactions.chunks(chunk_len) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, I'm confused why this is transactions and not transactions[chunk_len..].

@garious
Copy link
Contributor

garious commented Jun 26, 2018

This looks good to me, but definitely needs tests. And we need to document somewhere in ledger.rs that clients should not attempt to use a last_id from an entry with has_more=true.

@garious garious added automerge Merge this Pull Request automatically once CI passes and removed work in progress This isn't quite right yet labels Jun 26, 2018
@solana-grimes solana-grimes merged commit ac40c18 into solana-labs:master Jun 26, 2018
@rob-solana rob-solana deleted the entry.has_more branch July 12, 2018 16:35
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
)

Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.11.5 to 7.11.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.11.6/packages/babel-cli)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Apr 1, 2024
* [TieredStorage] enum-based AccountsFileProvider

* derive traits

* remove refs

---------

Co-authored-by: jeff washington <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leader cannot start with large number of tokens
3 participants