Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Move public IP address detection out of bash #499

Merged
merged 1 commit into from
Jun 30, 2018
Merged

Move public IP address detection out of bash #499

merged 1 commit into from
Jun 30, 2018

Conversation

mvines
Copy link
Contributor

@mvines mvines commented Jun 30, 2018

Includes further refinement/churn of the setup.sh/solana-fullnode-config` CLI arguments. The options are:

Use local address (may be a private IP):

$ ./multinode-demo/setup.sh
.. or ..
$ ./multinode-demo/setup.sh -l

Use the detected public address (forced for the snap-based fullnode daemon):

./multinode-demo/setup.sh -p

@mvines mvines requested a review from garious June 30, 2018 00:58
@mvines
Copy link
Contributor Author

mvines commented Jun 30, 2018

@garious I think this is a little nicer for the snap setup at least. My Rust is still pretty terrible so donno what you think about bringing in that curl create dependency

garious
garious approved these changes Jun 30, 2018
View reviewed changes
Copy link
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

garious
garious reviewed Jun 30, 2018
View reviewed changes
src/nat.rs Outdated
@@ -16,6 +19,31 @@ pub struct UdpSocketPair {
pub sender: UdpSocket, // Locally bound socket to send via public address
}

/// Tries to determine the public IP address of this machine, returns 0.0.0.0 on
/// failure
pub fn get_public_ip_addr() -> IpAddr {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should return a Result. There's enough things to go wrong.

@garious
Copy link
Contributor

garious commented Jun 30, 2018

Good thinking on defaulting local.

@mvines mvines force-pushed the public_ip branch 2 times, most recently from 84a1910 to 08edf46 Compare June 30, 2018 02:21
@mvines
Copy link
Contributor Author

mvines commented Jun 30, 2018

Gross this brings in an openssl dependency that's breaking sagan and the snap build.

@mvines mvines added the work in progress This isn't quite right yet label Jun 30, 2018
@garious
Copy link
Contributor

garious commented Jun 30, 2018

An openssl dep seems pretty unavoidable. A broken one is disappointing.

@garious
Copy link
Contributor

garious commented Jun 30, 2018

nat put a dependency on hyper. Might as well add https://docs.rs/reqwest/0.8.6/reqwest/?

@mvines mvines removed the work in progress This isn't quite right yet label Jun 30, 2018
@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Jun 30, 2018
@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Jun 30, 2018
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to merge conflict

@mvines
Copy link
Contributor Author

mvines commented Jun 30, 2018

🚍

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Jun 30, 2018
@solana-grimes solana-grimes merged commit 450f271 into solana-labs:master Jun 30, 2018
@mvines mvines deleted the public_ip branch July 8, 2018 03:10
CriesofCarrots pushed a commit that referenced this pull request Feb 28, 2020
@jackcmay
fix: flow expose transactionInstruction (#499)
5102202
mvines pushed a commit to mvines/solana that referenced this pull request Jun 15, 2020
@jackcmay @mvines
fix: flow expose transactionInstruction (solana-labs#499)
28a6409
mvines pushed a commit that referenced this pull request Jun 15, 2020
@jackcmay @mvines
fix: flow expose transactionInstruction (#499)
c31ca1f
godmodegalactus pushed a commit to godmodegalactus/solana that referenced this pull request Jan 10, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
165a874 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)
godmodegalactus pushed a commit to godmodegalactus/solana that referenced this pull request Mar 22, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
eaee34b 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
@masakazu12 masakazu12 mentioned this pull request Mar 22, 2024
Open
godmodegalactus pushed a commit to godmodegalactus/solana that referenced this pull request Mar 28, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
78141ac 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
willhickey pushed a commit that referenced this pull request Mar 29, 2024
@mergify @yihau @willhickey
v1.18: ci: fix some issues for the release pipeline (backport of #493) (
b12d05f 
#499)

ci: fix some issues for the release pipeline (#493)

* add TRIGGERED_BUILDKITE_TAG to the pipeline

* publish a pre-release for the release id

(cherry picked from commit b1e1799)

Co-authored-by: Yihau Chen <[email protected]>
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Apr 7, 2024
@mergify @yihau
v1.18: ci: fix some issues for the release pipeline (backport of sola…
415cccb 
…na-labs#493) (solana-labs#499)

ci: fix some issues for the release pipeline (solana-labs#493)

* add TRIGGERED_BUILDKITE_TAG to the pipeline

* publish a pre-release for the release id

(cherry picked from commit b1e1799)

Co-authored-by: Yihau Chen <[email protected]>
godmodegalactus pushed a commit to blockworks-foundation/solana that referenced this pull request Apr 15, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
e496b5b 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
godmodegalactus pushed a commit to blockworks-foundation/solana that referenced this pull request May 30, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
fcae767 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)

Update release URLs for jito-solana (solana-labs#589)

Backports solana-labs#595: correctly initialize account overrides (solana-labs#599)

Fix: Ensure set contact info to UDP port instead of QUIC (solana-labs#601)

Buffer bundles that exceed processing time and make the allowed processing time longer (solana-labs#609)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@garious garious garious approved these changes

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvines @garious @solana-grimes