This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix Erasure Index #7319
Merged
Fix Erasure Index #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7319 +/- ##
========================================
+ Coverage 80.4% 80.6% +0.2%
========================================
Files 244 244
Lines 47617 47766 +149
========================================
+ Hits 38297 38535 +238
+ Misses 9320 9231 -89 |
carllin
force-pushed
the
FixBlocktree
branch
2 times, most recently
from
f48338e to
66d7260
Compare
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2019
Fix Erasure Index Check to set the erasure presence (cherry picked from commit b55b646) # Conflicts: # ledger/src/blocktree.rs
carllin
added a commit
that referenced
this pull request
Dec 9, 2019
Fix Erasure Index Check to set the erasure presence (cherry picked from commit b55b646)
carllin
added a commit
that referenced
this pull request
Dec 9, 2019
Fix Erasure Index Check to set the erasure presence (cherry picked from commit b55b646)
carllin
added a commit
that referenced
this pull request
Dec 9, 2019
Fix Erasure Index Check to set the erasure presence (cherry picked from commit b55b646)
solana-grimes
pushed a commit
that referenced
this pull request
Dec 9, 2019
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jan 5, 2025
&mut was added in:
solana-labs#7319
because coding shreds were removed after recovering shreds.
That logic was remove in:
solana-labs#21052
and we don't need mutable references any more.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jan 6, 2025
&mut was added in:
solana-labs#7319
because coding shreds were removed after recovering the erasure batch.
That logic was removed in:
solana-labs#21052
and we don't need mutable references any more.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jan 7, 2025
&mut was added in:
solana-labs#7319
because coding shreds were removed after recovering the erasure batch.
That logic was removed in:
solana-labs#21052
and we don't need mutable references any more.
behzadnouri
added a commit
to anza-xyz/agave
that referenced
this pull request
Jan 7, 2025
&mut was added in:
solana-labs#7319
because coding shreds were removed after recovering the erasure batch.
That logic was removed in:
solana-labs#21052
and we don't need mutable references any more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The erasure index is not updated in
check_cache_coding_shreddoes not update the erasure index. Thus when the erasure status is queried here for recovery status: https://github.com/solana-labs/solana/blob/master/ledger/src/blocktree.rs#L389, it does not account for codes inserted here https://github.com/solana-labs/solana/blob/master/ledger/src/blocktree.rs#L364, so recovery may not occur even when possible.Summary of Changes
Update erasure index in
check_cache_coding_shredFixes #
Replay Stage Spikes up to 1.5s when idling:
Before:
After:
