Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

show rent model #7410

Merged
merged 1 commit into from
Dec 10, 2019
Merged

show rent model #7410

merged 1 commit into from
Dec 10, 2019

Conversation

rob-solana
Copy link
Contributor

Problem

rent's constraints aren't intuitive

Summary of Changes

support printing out some basics of the rent model

Fixes #

@mvines
Copy link
Contributor

mvines commented Dec 10, 2019

This would make an awesome new cli subcommand: solana show-rent

@rob-solana
Copy link
Contributor Author

This would make an awesome new cli subcommand: solana show-rent

would you rather a new RPC or augmentation of current one?

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #7410 into master will decrease coverage by 0.6%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #7410     +/-   ##
========================================
- Coverage    67.9%   67.2%   -0.7%     
========================================
  Files         245     245             
  Lines       57498   58018    +520     
========================================
- Hits        39044   39022     -22     
- Misses      18454   18996    +542

@mvines
Copy link
Contributor

mvines commented Dec 10, 2019

I don't see an obvious existing RPC API that we could graft onto so prolly a new one. But sombody adding a solana show-rent command isn't urgent and don't need to block this PR by any means

@rob-solana
Copy link
Contributor Author

I don't see an obvious existing RPC API that we could graft onto so prolly a new one. But sombody adding a solana show-rent command isn't urgent and don't need to block this PR by any means

    get_minimum_balance_for_rent_exemption(&self, data_len: usize)

@rob-solana rob-solana merged commit 7d6777a into solana-labs:master Dec 10, 2019
@rob-solana rob-solana mentioned this pull request Dec 10, 2019
2 tasks
@garious
Copy link
Contributor

garious commented Dec 10, 2019

Seems like a natural extension of solana fees.

@rob-solana rob-solana deleted the show-rent-model branch December 11, 2019 01:18
@rob-solana
Copy link
Contributor Author

#7413

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants