Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Add blockstore address-to-signature index #9367

Merged

Conversation

CriesofCarrots
Copy link
Contributor

Problem

For the history that an API node maintains, it's not possible to fetch the list of transactions that affect a given address. In order to be able to do that, we need a performant way to get address transaction information from blockstore.

Summary of Changes

  • Add AddressSignatures blockstore column
  • Write to AddressSignatures as part of transaction_status_service
  • Use TransactionStatus primary-index and pruning mechanisms to index and prune AddressSignatures

Toward #9317

@CriesofCarrots CriesofCarrots requested a review from mvines April 8, 2020 02:24
@CriesofCarrots CriesofCarrots force-pushed the blockstore-account-index branch from bf2ab9f to f172c60 Compare April 8, 2020 02:28
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #9367 into master will decrease coverage by 0.0%.
The diff coverage is 96.0%.

@@           Coverage Diff            @@
##           master   #9367     +/-   ##
========================================
- Coverage    81.1%   81.0%   -0.1%     
========================================
  Files         276     276             
  Lines       61908   62045    +137     
========================================
+ Hits        50233   50305     +72     
- Misses      11675   11740     +65     

@CriesofCarrots CriesofCarrots force-pushed the blockstore-account-index branch from f172c60 to ead5add Compare April 8, 2020 07:22
mvines
mvines previously approved these changes Apr 8, 2020
Copy link
Contributor

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're going to backport to v1.1/v1.0 later?

ledger/src/blockstore_db.rs Outdated Show resolved Hide resolved
ledger/src/blockstore_db.rs Outdated Show resolved Hide resolved
ledger/src/blockstore_meta.rs Outdated Show resolved Hide resolved
@CriesofCarrots
Copy link
Contributor Author

You're going to backport to v1.1/v1.0 later?

Easier to do it change by change, so I'll tag this one now.
Any reason not to backport to v1.0? ie. any reasonable doubt that we'll want the RPCs built on top of this in v1.0?

@mvines
Copy link
Contributor

mvines commented Apr 8, 2020

Any reason not to backport to v1.0? ie. any reasonable doubt that we'll want the RPCs built on top of this in v1.0?

TW talks to mainnet-beta, so 💯 on that v1.0 backport

@mergify mergify bot dismissed mvines’s stale review April 8, 2020 18:47

Pull request has been modified.

@CriesofCarrots CriesofCarrots added the automerge Merge this Pull Request automatically once CI passes label Apr 8, 2020
@solana-grimes solana-grimes merged commit 36e73ca into solana-labs:master Apr 8, 2020
mergify bot pushed a commit that referenced this pull request Apr 8, 2020
automerge

(cherry picked from commit 36e73ca)
mergify bot pushed a commit that referenced this pull request Apr 8, 2020
automerge

(cherry picked from commit 36e73ca)
solana-grimes pushed a commit that referenced this pull request Apr 8, 2020
solana-grimes pushed a commit that referenced this pull request Apr 8, 2020
@CriesofCarrots CriesofCarrots deleted the blockstore-account-index branch April 16, 2020 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants