Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 236 #874

Merged
merged 22 commits into from
May 9, 2024
Merged

Update 236 #874

merged 22 commits into from
May 9, 2024

Conversation

SpacialCircumstances
Copy link
Member

No description provided.

Metritutus and others added 22 commits May 4, 2024 19:10
…ionality and reduce template duplication.

* Updated statistic rows to show a question mark and tooltip if the stat is based on the player's scanning range.
* Added new Tick Income statistic row, which is shown if there are any financial analysts in the player's scanning range.
* Added calculateTickIncome() method to gameHelper.js.
* Updated getStarsOwnedByPlayer() to return an empty array if the player parameter value was null or undefined.
* Fixed token debt forgiveness between two players being displayed as tokens in the in-game chat between those players.
…r on the galaxy map on mobile to also send an additional tap event through to whatever modal that would open up afterwards (resulting in accidental infrastructure acquisition, etc).

    - Updated onClicked() method in carrier.js and star.js to run in a setTimeout() to allow the click/tap event to be fully processed before we'll have shown any modals that may result from that tap event.  This prevents the tap event that opened the modal also being picked up as a new tap event on that modal.
    - Updated onViewObjectRequested() method in MapObjectSelector component to not emit onOpenStarDetailRequested or onOpenCarrierDetailRequested.  These would be handled in the MainBar component, and ultimately lead to a call to store.commit() for MENU_STATES.STAR_DETAIL or MENU_STATES.CARRIER_DETAIL.  However, store.commit() for these menu states is also ultimately called as part of the map.clickStar() or map.clickCarrier() calls, meaning that (now that the click is deferred), the requested detail would open and then immediately close.
    - Updated onStarClicked() and onCarrierClicked() methods in map.js to support an additional property on the dic parameter for tryMultiSelect, to allow for programmatically selecting a carrier orbiting a star without it opening the star detail panel.
    - Updated onCarrierClicked() method in map.js to remove the orbiting check for a carrier, where it would select the star if you clicked on the carrier when it was orbiting a star, because we do actually want to open the carrier detail panel.
Fix KOTH when star is not in the exact center
…-forcing

Update simplex-noise and greatly increase irregular map seeds
@SpacialCircumstances SpacialCircumstances merged commit 6c558b7 into master May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants