Find and Replace dialog fixes #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks better, especially on a high DPI screen
The result was a corrupted text
pstranak-sw
commented
Mar 13, 2021
| @@ -494,10 +494,6 @@ private void InitializeComponent() | |||
| this.aboutSWQLStudioToolStripMenuItem.Text = "About SWQL Studio"; | |||
| this.aboutSWQLStudioToolStripMenuItem.Click += new System.EventHandler(this.aboutSWQLStudioToolStripMenuItem_Click); | |||
| // | |||
| // openFileDialog | |||
| // | |||
| this.openFileDialog.FileName = "openFileDialog1"; | |||
There was a problem hiding this comment.
Not really related to the "Find and Replace" dialog, but why not fix it anyway.
pstranak-sw
commented
Mar 13, 2021
| @@ -1080,7 +1073,7 @@ private CharacterRange ReplaceNext(bool searchUp) | |||
| if (rdoRegexR.Checked) | |||
| { | |||
| rr = new Regex(txtFindR.Text, GetRegexOptions()); | |||
| string selRangeText = Scintilla.GetTextRange(selRange.cpMin, selRange.cpMax - selRange.cpMin + 1); | |||
There was a problem hiding this comment.
Example of bad replace:
- query:
abc - search for regex:
b - replace with:
d - result was:
adcc
|
The dialog contains surprisingly lot of duplicated or unfinished code and copy-paste issues. This PR should fix the ones I encountered. What are the plans for the whole "ScintillaNET-FindReplaceDialog" component? Do only as few changes as possible? Delete everything we don't use (IncrementalSearch, FindAllResults, GoTo)? Refactor the code we use to simplify it? Are changes like this even OK, considering it's a 3rd-party code? |
|
Changes are available for testing in build 3.0.0.312 |
tdanner
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of fixes for issues in the "Find and Replace" dialog. One commit per issue.