Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events list per year is too wide #858

Closed
michielbdejong opened this issue Mar 13, 2024 · 3 comments · Fixed by #869
Closed

Events list per year is too wide #858

michielbdejong opened this issue Mar 13, 2024 · 3 comments · Fixed by #869
Labels
bug Something isn't working

Comments

@michielbdejong
Copy link
Contributor

In the 2023-redesign branch, all events for a given year are in a horizontal list.
This means they run off the screen when there are more than 5 events in one year.

@michielbdejong michielbdejong added the bug Something isn't working label Mar 13, 2024
@michielbdejong
Copy link
Contributor Author

Screenshot 2024-03-13 at 17 13 07

michielbdejong added a commit that referenced this issue Apr 4, 2024
@michielbdejong michielbdejong linked a pull request Apr 4, 2024 that will close this issue
csarven added a commit that referenced this issue Apr 5, 2024
@csarven
Copy link
Member

csarven commented Apr 5, 2024

Good catch. Please review / have a look at #869 aiming to resolve this. Since no typographical guidelines for various kinds of information was provided, we're bound to run into these random issues all over the website.

@TallTed
Copy link
Contributor

TallTed commented Apr 5, 2024

I have a feeling this fix/workaround is mainly aimed at larger viewports (typical for laptops, desktops, even large tablets), and may not solve the same problem for smaller viewports (typical for smaller tablets, smartphones, etc.).

It might be better to make that "horizontal list" scrollable when there are more than fit in any given viewport (which might be small even on a larger screen), such as what Google does with a product search.

@csarven csarven linked a pull request Apr 8, 2024 that will close this issue
michielbdejong pushed a commit that referenced this issue May 2, 2024
michielbdejong pushed a commit that referenced this issue May 2, 2024
michielbdejong pushed a commit that referenced this issue May 24, 2024
michielbdejong pushed a commit that referenced this issue Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants