Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS misaligned on main page #866

Closed
michielbdejong opened this issue Apr 4, 2024 · 3 comments
Closed

CSS misaligned on main page #866

michielbdejong opened this issue Apr 4, 2024 · 3 comments

Comments

@michielbdejong
Copy link
Contributor

Screenshot 2024-04-04 at 08 49 02
@csarven
Copy link
Member

csarven commented Apr 4, 2024

I presume this has to do with the new item being added to the homepage ( introduced in #863 ) and to handle arbitrary number of items. I've pushed a fix into d565ea3 . That should work. Let me know / close issue at will.

I've made the best guess here because we don't have IA / UX documentations or a style guide.

@michielbdejong
Copy link
Contributor Author

michielbdejong commented Apr 9, 2024

Much better, thanks a lot! That fixes the missing grid lines:
Screenshot 2024-04-09 at 14 42 33

But I think there still is a text indentation problem. I would expect texts to be left-aligned, so that "Develop an app with Solid" starts at the same x position as "Read about Solid". Instead it seems each text is centered?

@michielbdejong
Copy link
Contributor Author

That's better! And I learned something about CSS grids in the process :) Thanks!

Screenshot 2024-04-09 at 15 07 00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants