Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use storage or server in place of data pod #365

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

csarven
Copy link
Member

@csarven csarven commented Dec 17, 2021

Removes use of the term data pod in requirements in favour of server or storage. Leaves the the term "data pod" as is for now. It should be revisited for 1.0.

@csarven csarven added this to the ~First Public Working Draft milestone Dec 17, 2021
@csarven csarven requested a review from a team December 17, 2021 12:54
Copy link
Member

@matthieubosquet matthieubosquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplification and distinction between server and storage.

I am wondering if the term "Solid Server" would be better than simply "Server". I know it is derived from context and I'm not sure what it means for the use of spec:Server (do we need to use solid:Server subclassOf spec:Server instead?) but it seems potentially nice to be more specific.

protocol.html Outdated Show resolved Hide resolved
Copy link
Member

@elf-pavlik elf-pavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good change 👍
I didn't read the full diff due to ridiculous line length.

Co-authored-by: Matthieu Bosquet <[email protected]>
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it is good to use the term pod as an informal term and storage as the corresponding formal term.

Copy link
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Copy link
Member

@justinwb justinwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better ✅

Copy link
Member

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants