-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use storage or server in place of data pod #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplification and distinction between server and storage.
I am wondering if the term "Solid Server" would be better than simply "Server". I know it is derived from context and I'm not sure what it means for the use of spec:Server (do we need to use solid:Server subclassOf spec:Server instead?) but it seems potentially nice to be more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a good change 👍
I didn't read the full diff due to ridiculous line length.
Co-authored-by: Matthieu Bosquet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it is good to use the term pod as an informal term and storage as the corresponding formal term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Removes use of the term data pod in requirements in favour of server or storage. Leaves the the term "data pod" as is for now. It should be revisited for 1.0.