Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular clean commands, build commands, util for using workspace package in examples #1695

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Dec 19, 2024

This split the clean command to examples, packages, root - to more granularly clean up .vinxi/, .output/, node_modules/, dist/

Also, since the clean:root command removes the ./node_modules/ where rimraf is currently installed, I found it was better to use pnpx rimraf to always allow running the clean commands

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: a37ad1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@birkskyum birkskyum changed the title More thorough clean:all More thorough clean:all, and pnpx rimraf Dec 19, 2024
@birkskyum birkskyum changed the title More thorough clean:all, and pnpx rimraf Better clean commands, util for using workspace package in examples Dec 19, 2024
@birkskyum birkskyum changed the title Better clean commands, util for using workspace package in examples Granular clean commands, build commands, util for using workspace package in examples Dec 19, 2024
@birkskyum birkskyum force-pushed the more-thorough-clean branch 2 times, most recently from 9d5e08d to 4980931 Compare December 20, 2024 17:57
.filter(file => statSync(join(examplesDir, file)).isDirectory());

// Process each example's package.json
examples.forEach(example => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly does this file do?

Copy link
Member Author

@birkskyum birkskyum Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it sets the "@solidjs/start": "workspace:*" in all the examples, so they can be used for local testing.

@brenelz
Copy link
Contributor

brenelz commented Jan 24, 2025

Some conflicts to resolve

@birkskyum birkskyum force-pushed the more-thorough-clean branch from 37eaed4 to f420154 Compare January 24, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants