-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular clean commands, build commands, util for using workspace package in examples #1695
base: main
Are you sure you want to change the base?
Conversation
|
More templates
commit: |
pnpx rimraf
pnpx rimraf
9d5e08d
to
4980931
Compare
.filter(file => statSync(join(examplesDir, file)).isDirectory()); | ||
|
||
// Process each example's package.json | ||
examples.forEach(example => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what exactly does this file do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it sets the "@solidjs/start": "workspace:*"
in all the examples, so they can be used for local testing.
Some conflicts to resolve |
37eaed4
to
f420154
Compare
This split the clean command to examples, packages, root - to more granularly clean up
.vinxi/
,.output/
,node_modules/
,dist/
Also, since the clean:root command removes the
./node_modules/
where rimraf is currently installed, I found it was better to usepnpx rimraf
to always allow running the clean commands