Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress server-function test #1719

Merged

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Jan 22, 2025

This adds cypress, and a small test that simply prints to the DOM the result of isServer when run in a client component, and within a server function.

It's executed manually in two steps right now:

  1. Go to /tests/server-function and run pnpm dev to launch the server of this barebones project

  2. Run in the repo root pnpm run cy:run (or for UI run cy:open)

I've added a github workflow too

cc @atilafassina , @brenelz

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 56e827f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@birkskyum birkskyum force-pushed the add-server-function-e2e-test-with-cypress branch from 07abc7b to fe73291 Compare January 22, 2025 20:28
Copy link
Member

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests!!!! 🎉

@atilafassina atilafassina merged commit 7f4a7d1 into solidjs:main Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants