Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the extension with the latest solidus_dev_support defaults #95

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Update the extension with the latest solidus_dev_support defaults #95

merged 2 commits into from
Oct 6, 2020

Conversation

elia
Copy link
Member

@elia elia commented Oct 5, 2020

No description provided.

@elia elia requested a review from seand7565 October 5, 2020 14:47
@elia elia force-pushed the elia/dev-support branch 2 times, most recently from 2d5ba0d to 73e5f6b Compare October 5, 2020 14:59
@elia elia force-pushed the elia/dev-support branch from 73e5f6b to d2f7341 Compare October 5, 2020 15:01
@elia elia self-assigned this Oct 5, 2020
@elia elia added the chore Needs to be done, for necessity or for the well-being of the project, not related to a feature label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #95 into master will decrease coverage by 0.16%.
The diff coverage is 77.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   90.09%   89.94%   -0.15%     
==========================================
  Files          29       30       +1     
  Lines         454      457       +3     
==========================================
+ Hits          409      411       +2     
- Misses         45       46       +1
Impacted Files Coverage Δ
...idus_paypal_commerce_platform/orders_controller.rb 73.53% <ø> (ø)
...commerce_platform/install/templates/initializer.rb 0.00% <0.00%> (ø)
lib/solidus_paypal_commerce_platform.rb 100.00% <100.00%> (+8.34%) ⬆️
lib/solidus_paypal_commerce_platform/client.rb 91.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4af6b...d2f7341. Read the comment docs.

@elia elia marked this pull request as ready for review October 5, 2020 16:24
@seand7565
Copy link
Contributor

Reviewed & tested, all looks good! Thanks @elia !

@seand7565 seand7565 merged commit ff08057 into master Oct 6, 2020
@seand7565 seand7565 deleted the elia/dev-support branch October 6, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seand7565 seand7565 seand7565 approved these changes

Assignees

@elia elia

Labels
chore Needs to be done, for necessity or for the well-being of the project, not related to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @seand7565