Fix a few new rubocop "offenses"

solidusio · Oct 5, 2020 · 73e5f6b · 73e5f6b
1 parent 8aaef9d
commit 73e5f6b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/app/controllers/solidus_paypal_commerce_platform/orders_controller.rb b/app/controllers/solidus_paypal_commerce_platform/orders_controller.rb
@@ -64,10 +64,12 @@ def paypal_address_params
         ],
         recipient: [
           :email_address,
-          name: [
-            :given_name,
-            :surname,
-          ]
+          {
+            name: [
+              :given_name,
+              :surname,
+            ]
+          }
         ]
       )
     end

diff --git a/lib/solidus_paypal_commerce_platform/client.rb b/lib/solidus_paypal_commerce_platform/client.rb
@@ -15,7 +15,7 @@ class Client
 
     attr_reader :environment
 
-    def initialize(test_mode: nil, client_id:, client_secret: "")
+    def initialize(client_id:, client_secret: "", test_mode: nil)
       test_mode = SolidusPaypalCommercePlatform.config.env.sandbox? if test_mode.nil?
       env_class = test_mode ? PayPal::SandboxEnvironment : PayPal::LiveEnvironment
 

diff --git a/spec/features/frontend/product_spec.rb b/spec/features/frontend/product_spec.rb
@@ -18,14 +18,14 @@ def paypal_script_options
     end
 
     it "generates a js file with the correct credentials and intent attached" do
-      visit '/products/' + product.slug
+      visit "/products/#{product.slug}"
       expect(paypal_script_options).to include("client-id=#{paypal_payment_method.preferences[:client_id]}")
     end
 
     context "when auto-capture is set to true" do
       it "generates a js file with intent capture" do
         paypal_payment_method.update(auto_capture: true)
-        visit '/products/' + product.slug
+        visit "/products/#{product.slug}"
         expect(paypal_script_options).to include("client-id=#{paypal_payment_method.preferences[:client_id]}")
         expect(paypal_script_options).to include("intent=capture")
       end
@@ -34,7 +34,7 @@ def paypal_script_options
     describe "order creation" do
       before do
         allow_any_instance_of(Spree::Core::ControllerHelpers::Store).to receive(:current_store) { store }
-        visit '/products/' + product.slug
+        visit "/products/#{product.slug}"
 
         # Stubbing out paypal methods since their JS doesn't load in correctly on tests
         page.execute_script("paypal = {}")