With oj gem - ActionView::Template::Error Infinity not allowed in JSON

[hhff]

Steps to reproduce

Load an order from the Solidus Checkouts API with a Line Item Variant with track_inventory: false, using the following responder:

respond_with(@order, default_template: 'spree/api/orders/show', status: 200)

Actual behavior

The API will throw: ActionView::Template::Error Infinity not allowed in JSON.

Source of the issue:

solidus/api/app/views/spree/api/variants/_small.json.jbuilder

Line 8 in 96b30d6

json.total_on_hand(variant.total_on_hand)

As it corresponds to:

solidus/core/app/models/spree/stock/quantifier.rb

Line 26 in fb70a41

Float::INFINITY

Expected behavior

I would expect that in the case track_inventory is false, the _small.json.jbuilder template would not include the total_on_hand attribute.

System configuration

Solidus Version: 2.4.2

[jhawthorn]

I wasn't able to reproduce this, maybe I missed something.

I added a spec to the orders_controller (which renders the same partials and is easier to test), and it rendered without error.

jhawthorn@5ae69a7

[hhff]

Hmm - will take a closer look a bit later, but perhaps it's because we're using OJ gem 'oj', '~> 3.3.5'

…

On Mon, Jan 8, 2018 at 5:40 PM John Hawthorn ***@***.***> wrote: I wasn't able to reproduce this, maybe I missed something. I added a spec to the orders_controller (which renders the same partials and is easier to test), and it rendered without error. ***@***.*** <jhawthorn@5ae69a7> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2486 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACu4_MYIB17ftX7n9KITE1Ya-10bN14Gks5tIplpgaJpZM4RTXJZ> .

[jhawthorn]

Yep! oj seems to be the culprit

[SebAshton]

Anyone else stumbling into this error, the solution is to set the following in an initializer:

# https://github.com/ohler55/oj/blob/master/pages/Options.md#nan-symbol
# Fixes issue with Infinity in JSON

require 'oj'

Oj.default_options = {
  mode: :compat,
  nan: :huge
}