Remove wait_for_ajax calls and deprecate #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 30, 2016 13:00
The matcher below should appropriately wait on the shipment re-appearing
Just look for the successfully deleted message
Look for the message that it was successfully removed instead
The alert box that pops up has no reasonable error message, just "undefined". Rather than fixing that behavior I'm getting a test in for it first.
The waiting matcher directly below is good enough
wait_for_ajax is a relic left over from the spree codebase when people had a poor understanding of how capybara worked (and it was harder to understand what and how matchers waited). We can now mark it deprecated in the hopes people fix up their test suites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_for_ajax is a relic left over from the spree codebase when people
had a poor understanding of how capybara worked (and it was harder to
understand what and how matchers waited).
We can now mark it deprecated in the hopes people fix up their test
suites.