Update code styles for /cart #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
suggested changes
Feb 22, 2017
| @@ -16,7 +16,7 @@ | |||
| <div data-hook="inside_cart_form"> | |||
|
|
|||
| <div data-hook="cart_items"> | |||
| <%= render :partial => 'form', :locals => { :order_form => order_form } %> | |||
| <%= render 'form', order_form: order_form, order: @order %> | |||
There was a problem hiding this comment.
Probably don't need to pass both order_form and order in, since order can be found via order_form.object.
If the goal is to make the code in the form partial nicer, it would be better to just store order as a local there.
There was a problem hiding this comment.
You mean to have this in _form:
<% order = order_form.object %>?
vfonic
force-pushed
the
cart-form-code-styling
branch
from
51d2db1 to
91688d9
Compare
mamhoff
approved these changes
Feb 24, 2017
* Use ruby 1.9 hash style
* Don't use @ instance variable in partial
* Replace `order_form.object` with `order`
* Replace
`render :partial => '...', :locals => { ... }`
with
`render '...', { ... }`
vfonic
force-pushed
the
cart-form-code-styling
branch
from
91688d9 to
caca97e
Compare
|
Resolved merge conflicts with |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
order_form.objectwithorderrender :partial => '...', :locals => { ... }with
render '...', { ... }