[WIP] Update admin shipments page dynamically #1731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need to cautiously prefix files with lines like:
Spree.Models = (Spree.Models || {})
Previously we were declaring Spree to be a CoffeeScript class. This was harmless, because it was compiled into an empty function, but also unnecessary, because it had no class methods and was never used as a class.
This file's history was already replaced by the previous commit, so we might as well convert to plain JS at the same time. This is the only CoffeeScript (now only JS) file in the solidus_core gem, so it can now in theory be used in an app without needing to pull in CoffeeScript (assuming the app doesn't include solidus_frontend or soldius_backend).
Also avoids shipments global.
jhawthorn
force-pushed
the
shipments_ajax_updates
branch
from
2d0c004 to
81246ae
Compare
|
@jhawthorn is this still something you are working on or can this be closed? |
|
I am still working on this but will open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review
Similar to (and build on top of) #1715, but for the more complex task of splitting and editing shipments.