-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update paperclip dependency #1749
Conversation
It it possible to support both paperclips? I imagine some users will still have some random gems still requiring |
@jhawthorn Great point. Would you suggest simply removing the version requirement altogether? |
It's good for us to be pessimistic about supporting future major versions. They'll bump these versions only when they have a major change, so it's best to double check each time there is a new one that we can still use it. What I'd like best here is:
|
@jhawthorn That sounds great. Done & done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Oops I had typod my suggestion ( |
@jhawthorn No prob! But it looks like something weird got into the changelog by accident. Let’s just take that out before we merge. |
`paperclip` 4.x depends on `aws-sdk` 1.x, which is being deprecated. This updates the dependency to `paperclip` 5.x, which depends on the more recent `aws-sdk` 2.x.
Whoops. Multitasking fail. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
paperclip
4.x depends onaws-sdk
1.x, which is being deprecated.This updates the dependency to
paperclip
5.x, which depends on the more recentaws-sdk
2.x.