Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update paperclip dependency #1749

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Conversation

brchristian
Copy link
Contributor

paperclip 4.x depends on aws-sdk 1.x, which is being deprecated.

This updates the dependency to paperclip 5.x, which depends on the more recent aws-sdk 2.x.

@jhawthorn
Copy link
Contributor

jhawthorn commented Feb 27, 2017

It it possible to support both paperclips? I imagine some users will still have some random gems still requiring aws-sdk 1.x

@brchristian
Copy link
Contributor Author

@jhawthorn Great point. Would you suggest simply removing the version requirement altogether?

@jhawthorn
Copy link
Contributor

jhawthorn commented Feb 27, 2017

It's good for us to be pessimistic about supporting future major versions. They'll bump these versions only when they have a major change, so it's best to double check each time there is a new one that we can still use it.

What I'd like best here is:

s.add_dependency 'paperclip', ['>= 4.2', '< 6']

@brchristian
Copy link
Contributor Author

@jhawthorn That sounds great. Done & done.

Copy link
Contributor

@jhawthorn jhawthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jhawthorn
Copy link
Contributor

Oops I had typod my suggestion (=> vs >=). Pushed up a fix (hope that's okay).

@brchristian
Copy link
Contributor Author

@jhawthorn No prob! But it looks like something weird got into the changelog by accident. Let’s just take that out before we merge.

`paperclip` 4.x depends on `aws-sdk` 1.x, which is being deprecated.

This updates the dependency to `paperclip` 5.x, which depends on the more recent `aws-sdk` 2.x.
@jhawthorn
Copy link
Contributor

jhawthorn commented Feb 27, 2017

@jhawthorn No prob! But it looks like something weird got into the changelog by accident. Let’s just take that out before we merge.

Whoops. Multitasking fail. Fixed.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jhawthorn jhawthorn merged commit d9d54bd into solidusio:master Mar 1, 2017
@brchristian brchristian deleted the patch-4 branch March 1, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants