Convert customer details page to backbone #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This encapsulates the details of using select2
This code did nothing because there are no fields named like `#order_bill_address_attributesfirstname`, they're named `#order_bill_address_attributes_firstname`. This bug was introduced in Spree 1.2, and I've heard no complaints about this behaviour, so we should leave it as-is.
|
👍 for backbone; we use it widely (we use Mariontte/Backbone) and love it. in particular, it boots extremely fast and its source code is accessible (readable). |
tvdeyen
approved these changes
Mar 10, 2017
| var $state_select = this.$state_select; | ||
| this.states.each(function(state) { | ||
| $state_select.append( | ||
| $('<option>').prop('value', state.id).text(state.get("name")) |
There was a problem hiding this comment.
Do we need a check for already existing states here? Or is the select always empty at this point?
There was a problem hiding this comment.
Yep, we empty the <select> on line 42.
cbrunsdon
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace the jQuery soup of checkouts/edit.js and address_states.js with backbone models and views.
There were a number of issues with the existing code:
checkouts.jswas callback hell. Worst case was setting thestate_id, which had to be done inside a select2 callback, and a callback from an ajax request inside of update_stateThe conversion to backbone added a fair number of lines, which I feel I should justify. From about 135 lines between
edit.jsandaddress_states.jsto about 250 lines between the four new backbone views.This PR adds two way bindings between all the form inputs on this page. This allows our top level view to be oblivious to the details of the subview (in particular the awkwardness of state selection). Specifically I'd like to point to the existing code when selecting a customer vs the new code