Upgrade to Bootstrap 4.0.0.alpha6 #1776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
changed the title
|
Hmm we seem to be running into twbs/bootstrap#21607 so we may have to put off this upgrade |
|
I tried setting EDIT: setting |
jhawthorn
force-pushed
the
bootstrap-4-0-0-beta6
branch
from
d05d15a to
76ace5b
Compare
Previously normalize.css set table's border-spacing to 0, bootstrap now uses reboot.css, which doesn't reset this property.
Bootstrap has removed col-xs-N in the latest alphas.
This works around a bootstrap issue resulting in
Error: Tooltip is transitioning
We should be able to re-enable this for the next release if desired.
This works around a bootstrap 4.0.0.alpha6 issue resulting in
Error: Tooltip is transitioning
We should be able to re-enable this for the next release if desired.
jhawthorn
force-pushed
the
bootstrap-4-0-0-beta6
branch
from
76ace5b to
affa680
Compare
|
Closing for #1816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were on Bootstrap 4.0.0.alpha2. Changes can be seen in their Release notes
Notable to us:
col-xs-3et al. are gone. Replaced withcol-3.I can't be 100% sure this didn't mess up any styling, but in a quick browse through the admin I didn't spot anything off.