Deprecate simple_current_order #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-brough
approved these changes
May 22, 2017
ericsaupe
changed the title
ericsaupe
force-pushed
the
simple-current-store
branch
2 times, most recently
from
2032ce5 to
f361b4f
Compare
mamhoff
reviewed
May 22, 2017
| @@ -14,8 +14,9 @@ module Order | |||
| helper_method :simple_current_order | |||
| end | |||
|
|
|||
| # Used in the link_to_cart helper. | |||
| def simple_current_order | |||
There was a problem hiding this comment.
You can use
deprecate simple_current_order: :current_order, deprecator: Spree::Deprecation
Which does the same thing more concisely.
There was a problem hiding this comment.
I like this a lot better, I'll make the change. Thanks!
Using the current_order_params sets the store and user similar to the current_order method.
The `#simple_current_order` method is duplicating many of the functions already found in `#current_order`. `simple_current_order` was finds an order by token or user, updates ip_address, and creates an order if one is not found. All functions that are already accomplised in `#current_order` which also does more than `#simple_current_order` making it the preferred method.
ericsaupe
force-pushed
the
simple-current-store
branch
from
f361b4f to
26d81b2
Compare
mamhoff
approved these changes
May 22, 2017
harmonymjb
pushed a commit
to alarmgrid/solidus_bootstrap_frontend
that referenced
this pull request
Jan 21, 2020
harmonymjb
pushed a commit
to alarmgrid/solidus_bootstrap_frontend
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug found in #1700 and deprecates
simple_current_orderbecause it's function is duplicated withcurrent_order