Distributed Amount Calculator #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graygilmore
commented
May 23, 2017
graygilmore
commented
May 23, 2017
graygilmore
commented
May 23, 2017
mamhoff
approved these changes
May 23, 2017
backend/app/views/spree/admin/promotions/calculators/weighted_rate/_fields.html.erb
Show resolved
Hide resolved
jordan-brough
suggested changes
May 23, 2017
backend/app/views/spree/admin/promotions/actions/_create_item_adjustments.html.erb
Outdated
Show resolved
Hide resolved
|
Great comments. Going to look at these now. |
|
You should add a screenshot of what the admin UI looks like for this calculator :) Best one I've seen I think. Edit: Oops, either you added it after I looked or I missed it at first. Either way: Great! |
This removes the need for specifying `partial` and `locals` keys as well as bringing the line length down.
We'll be introducing a new calculator for promotions that will allow order-level promotion values to be applied through line item adjustments. This class keeps some of the more complicated logic out of the calculator as it has to reach up to the order and calculate values on multiple line items.
graygilmore
force-pushed
the
weight-rate-calculator
branch
from
a0d97e7 to
1d3c062
Compare
This calculator allows us to use order level promotions ("Save $50 on
your order") and spread that $50 over all of the line items. This
calculator shoots logic off to another class to handle the calculations.
Each line item needs to call out to the DistributedAmountsHandler
separately which is annoying but each line item needs to be aware of the
order as a whole.
The calculator spreads the discount amount among each of the line items
relative to their price. This means that more expensive items will
receive a greater share of the discount.
graygilmore
force-pushed
the
weight-rate-calculator
branch
from
1d3c062 to
4b00354
Compare
isaacfreeman
approved these changes
May 23, 2017
backend/app/views/spree/admin/promotions/calculators/weighted_rate/_fields.html.erb
Outdated
Show resolved
Hide resolved
backend/app/views/spree/admin/promotions/calculators/weighted_rate/_fields.html.erb
Outdated
Show resolved
Hide resolved
backend/app/views/spree/admin/promotions/calculators/weighted_rate/_fields.html.erb
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows admins to create order level promotions that get applied through line item adjustments. For example "Save $50 off your order" and we spread the $50 through line item adjustments.
Example
If you had a $15 promotion that you wanted to spread over three line items with differing prices:
Notes
This will help move us in the direction of removing order-level adjustments as discussed here: #1913
This may even allow us to deprecate a flat rate order-level adjustment if we wanted to move in that direction.
Admin Screenshot