WIP: Order not triggering callbacks on shipments

[skukx]

When complete! is called on order, it then updates all the shipments
to ready. The problem is that this update skips state_machine
transition callbacks. Write spec to show this behavior.

[kennyadsl]

Also, from Rails 4+ that update! method on Spree::Shipment is overriding the ActiveRecord update! method and I don't think it has been done intentionally.

P.S. We probably have the same problem on Spree::Order

[cbrunsdon]

Hi @skukx, a few of us are in the middle of a conversation about this IRL and we're trying to get a better picture about how people are using the state machine on shipments (because as you can see it has a lot of issues).

Can you share what it is you're looking for on ready being called? Is there a "better" time you actually want it called, but are hooking into ready because it should be easy, or is shipment.ready for sure the exact time you want something to be executed?

[skukx]

@cbrunsdon right now we are working on integrating with our WMS. The idea was to send our wms what items to ship as the Solidus::Shipment moves to ready. This would ensure that payment is full, and that there is enough stock. Normally the WMS could probably account for the stock portion but the WMS we have a contract with doesn't have the most friendly API.

[jhawthorn]

We understand the problem here and desire to have a better way to hook into state changes. We'd like to find a better way for stores to hook into events like orders completing, payments being received, and shipments being shipped.

Unfortunately the Shipment state machine isn't really a state machine. It's mostly a calculated state field. I'm not even sure the "ready" state should exist.

Closing because this isn't mergeable or immediately actionable.