Remove responders dependency from core #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've removed the responders code from core, so the only thing that is using the responders gem is inside the api now
cbrunsdon
force-pushed
the
remove_responder_from_core
branch
from
17499ed to
1850853
Compare
|
Okay with #1956 gone this is good to go whenever someone has a sec |
jhawthorn
changed the title
2 tasks
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Jun 16, 2023
We removed the responders dependency from solidus_core in solidusio#2090. However, we forgot to remove the use of the responders API from solidus_core. We weren't catching this because all consumers of solidus_core's `Spree::BaseController` had the responders gen as a dependency (see solidusio#3336)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the responders dependency to the API, the place where we actually use it.
I'll rebase this once #1956 is merged, I just want to run tests.