Add #gallery to Spree::Variant and Spree::Product
#2323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wraps the `has_many :images` association of Variants. If we decide to change the implementation of images on variants (or get rid of them completely) this will keep the API from breaking.
This wraps the collection of images that a product gets from its variants. If we decide to change the implementation of images on products (or remove them completely) this will keep the API from breaking.
Uses `Product#gallery`. The thumbnails for products no longer include the master variant's images. Showing a thumbnail for the master variant doesn't make sense since that variant isn't something that a user can elect to buy.
houndci-bot
reviewed
Oct 24, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming Error: The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. (obsolete configuration found in .rubocop.yml, please update it)
jhawthorn
suggested changes
Oct 24, 2017
| @@ -1,19 +1,10 @@ | |||
| <%# no need for thumbnails unless there is more than one image %> | |||
There was a problem hiding this comment.
We can't change the behaviour of this file. We can't have it so users upgrade and the logic for displaying images on the frontend changes (I think it's likely in a ton of stores that this wouldn't be caught before production).
| # | ||
| # @return [Enumerable] of media for a variant | ||
| def gallery | ||
| Variant.reflect_on_association(:images) ? association(:images).reader : [] |
There was a problem hiding this comment.
We define this association, so we shouldn't test for it. If this is to prepare for a future paperclip removal PR, it should be done later.
| # | ||
| # @return [Enumerable] of media for a product (and its variants) | ||
| def gallery | ||
| if Product.method_defined?(:variant_images) |
There was a problem hiding this comment.
We define this association, so we shouldn't test for it. If this is to prepare for a future paperclip removal PR, it should be done later.
Merged
|
Closed in favour of #2337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lightweight version of #625.
Related to #2324, I think this is a good starting point to begin opening up an interface for different image upload implementations.