Fix spec failure due to DB order #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Mar 7, 2018
| @@ -39,7 +39,7 @@ | |||
| end | |||
| end.to change { Spree::Shipment.count }.by(1) | |||
|
|
|||
| new_shipment = order.shipments.last | |||
| new_shipment = (order.shipments.to_a - [shipment])[0] | |||
There was a problem hiding this comment.
Why not order.shipments.order(:created_at).last or order.shipments.sort_by(&:created_at).last if we don't want to reload the shipments again? Would be more readable.
There was a problem hiding this comment.
I did this out of habit due to MySQL second timestamp issues, but this isn't necessary as of #2598 🎉. I will use your suggestion.
There was a problem hiding this comment.
Ah. Thanks for clarifying. I always forget the darn mysql default precision.
The shipments association here was being loaded in the recalculate. The association itself isn't ordered, so the shipments could be in any order. Because of this, shipments.last wasn't necessarily the most recent shipment, and this spec could fail.
jhawthorn
force-pushed
the
fix_db_order_error_shipments
branch
from
5900895 to
6586178
Compare
|
Merging ahead of our usual time period, as this fixes spec issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shipments association here was being loaded in the recalculate. The association itself isn't ordered, so the shipments could be in any order. Because of this, shipments.last wasn't necessarily the most recent shipment, and this spec could fail.
This probably started failing after #2555 was merged