Update promotion-actions.html.md #2781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Action must be namespaced.
kennyadsl
approved these changes
Jun 21, 2018
gmacdougall
requested changes
Jun 29, 2018
| @@ -82,7 +82,7 @@ You must then register the custom action in an initializer in your | |||
| `config/initializers/` directory: | |||
|
|
|||
| ```ruby | |||
| Rails.application.config.spree.promotions.actions << MyPromotionAction | |||
| Rails.application.config.spree.promotions.actions << Spree::Promotion::Actions::MyPromotionAction | |||
There was a problem hiding this comment.
I don't believe this is a pattern we wish to encourage. If this has resolution issues as it is I think that:
Rails.application.config.spree.promotions.actions << ::MyPromotionActionor
Rails.application.config.spree.promotions.actions << MyNamespace::MyPromotionActionwould be preferrable.
There was a problem hiding this comment.
What I suggested is what worked for me, but if either one of these two alternatives resolve as well and the pattern is preferred, sure, why not.
|
Hey @bazfer, are you planning on making this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action must be namespaced.