-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customizing the promotion code batch mailer class #2796
Allow customizing the promotion code batch mailer class #2796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some code comment changes, thanks!
core/lib/spree/app_configuration.rb
Outdated
@@ -307,6 +307,15 @@ def default_pricing_options | |||
# @api experimental | |||
class_name_attribute :shipping_rate_tax_calculator_class, default: 'Spree::TaxCalculator::ShippingRate' | |||
|
|||
# Allows providing your own Mailer for order mailer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment needs to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, done
core/lib/spree/app_configuration.rb
Outdated
@@ -307,6 +307,15 @@ def default_pricing_options | |||
# @api experimental | |||
class_name_attribute :shipping_rate_tax_calculator_class, default: 'Spree::TaxCalculator::ShippingRate' | |||
|
|||
# Allows providing your own Mailer for order mailer. | |||
# | |||
# @!attribute [rw] order_mailer_class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Adds the ability to replace default promotion code batch mailer class with a custom one, so there's no need to override default partials