Skip forgery protection in api controllers #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how new (Rails 5.2+) apps are generated by default starting from rails/rails@ec4a836 commit. This change makes api specs fail since json POST requests are now under forgery protection but we have a token based authentication in place that should replace this check. This will be handled in a next commit. We are applying this changes only when rails version is >= 5.2
link_to with `method: :put` uses rails-ujs to append the csfr token to the request taking that form a specific tag in the <head>. These specs was only passing since forgery protection was previously disabled in test mode.
Rails is now enabling forgery protection by default so we need to explicitly disable it for api requests, as described here: http://api.rubyonrails.org/classes/ActionController/RequestForgeryProtection.html
kennyadsl
force-pushed
the
forgery-protection-api
branch
from
62f3245 to
6f3f172
Compare
ericsaupe
approved these changes
Sep 19, 2018
BenMorganIO
reviewed
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2799
Rails is now enabling forgery protection by default so we need to explicitly disable it for api requests, as described here:
http://api.rubyonrails.org/classes/ActionController/RequestForgeryProtection.html
This PR also enables forgery protection by default in the specs dummy app so that we can really test that the api code is working in a real Rails 5.2+ environment.