Fix double highlight on admin menu when Product Stock tab is active

[aitbw]

Refs: #2950

Here's a screenshot to demonstrate how the menu looks after the proposed patch

Open to suggestions! 🙌

[jacobherrington]

This makes sense to me! If we find this in more places we should add a test for it, but I think this fixes #2950

Thanks @aitbw!

[tvdeyen]

I don’t know if we want to handle this particular case like this in a helper. Isn’t there a way to fix this with using match_path for the problematic tabs?

[jacobherrington]

@tvdeyen I agree, if it seems like there are more examples of this problem, but if it is only on the product stock page this solves that issue.

[tvdeyen]

Sorry, I cannot give my approval to that solution. Please let us try to fix the problem in a different way.

[jacobherrington]

@aitbw let's try to approach the problem from another perspective. Instead of removing the class from the incorrect element, we should make sure it never gets applied. Does that make sense?

[tvdeyen]

This is my alternative approach #2969 to this issue.

@aitbw thanks for working on this and sorry for the rejection, but we would like to fix the issue at the root cause. Having to deal with issue like this in a helper is not ideal. That's why I made this alternative approach. Thanks for the contribution. That's very much appreciated.

[jacobherrington]

I'm going to suggest we go with the solution in #2969. Thanks for sharing your code @aitbw!

[aitbw]

Don't worry @jacobherrington @tvdeyen, I completely understand and I'm more fond of a solution like #2969 ☺️