Fix coupon code placeholder value. #3009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
solidus/frontend/app/views/spree/checkout/_coupon_code.html.erb
Line 4 in 4497ef5
This is not valid code
You probably thought i18n would be used, but it’s not. Rails cast it to string and renders at it is.
Placeholder attribute can be string or true. If it is true then rails use human attribute name for order#coupon_code. FYI: https://stackoverflow.com/questions/25677031/how-do-i-translate-placeholder-text-in-rails-4