-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Netlify site for yard docs #3019
Conversation
We want to deploy several sites from the same repo (guides and docs) and therefore need to use the admin UI to configure them.
We do not need to install all three database adapters at once. As we already set the `DB` env var during CI builds and the local sandbox runs with sqlite anyway, we can safely only install these gems on demand.
@tvdeyen is the Netlify failure normal here? |
@kennyadsl No. I need to make some more adjustments. Stay tuned |
Although there is the `--yardopts` file option and we only build docs for the `/core` (yet), I think it is best to share the options for all subfolders. Also does not require the gem on boot as we only run yard via command line anyway.
@kennyadsl ready ✅ |
Ideally we would only install gems that are necessary to build the docs (namely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tvdeyen !!!!
@kennyadsl thanks. I was able to disable all gem groups we don't need with setting the ENV var
in the Netlify admin. This should safe some resources 🐳 |
The local Gemfile (only used for CI and tooling) was grouped for frontend and backend only yet. In order to be able to install only a subset of gems (for generating docs for example) we should group all gems.
By grouping all gems I was able to reduce the gems needed to install to just https://app.netlify.com/sites/solidus-docs/deploys/5c2de220b7945d0008107d6c |
With that gem grouping change we should be able to only install the gems needed to build the current sub project. Currently we are always installing all gems for each subproject. I will prepare another PR to make the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tvdeyen !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Preparations for deploying the yard docs on Netlify.