Upgrade to CanCanCan 3.0 #3174
Closed
Upgrade to CanCanCan 3.0 #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coorasse
changed the title
Closed
tvdeyen
reviewed
May 16, 2019
| @@ -30,7 +30,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'activemerchant', '~> 1.66' | |||
| s.add_dependency 'acts_as_list', '~> 0.3' | |||
| s.add_dependency 'awesome_nested_set', '~> 3.0', '>= 3.0.1' | |||
| s.add_dependency 'cancancan', '~> 2.2' | |||
| s.add_dependency 'cancancan', '~> 3.0' | |||
There was a problem hiding this comment.
It seams we are still able to support cancancan 2.x as well? We should not force everybody else to upgrade to 3.0 as well. Could we set a lower bound of >= 2.2 and upper bound of < 4.0?
kennyadsl
dismissed
their stale review
I think Thomas is right, we should be able to not lock cancancan version here
|
Closing because it doesn't look like we need this anymore. @coorasse feel free to correct me if I'm wrong! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to upgrade to cancancan 3.0 without the assle of rewriting all the permissions logic. see #3148
It basically overrides the changes to the
mergemethod of Ability.rb which were breaking solidus permissions mechanism.It should be seen as a temporary patch, so that the "proper" way of managing permissions can be released in the future in a major 3.0 release.
This allows to migrate to Rails 6.0.