Remove "Add product" in admin order shipments page #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should close #3085. Thanks for picking up the work on this one @spaghetticode! 🍝 Since this does affect the UI, do you mind adding a screenshot? |
|
@jacobherrington thanks for the input, it makes sense 👍 |
jacobherrington
approved these changes
May 29, 2019
kennyadsl
added
changelog:solidus_backend
|
As discussed during the Solidus core team meeting, before removing this functionality by merging this PR, we should provide an extension or similar mean that will allow users willing to continue to use this feature to do so. |
tvdeyen
approved these changes
Aug 22, 2019
spaghetticode
force-pushed
the
no-product-add-at-shipments
branch
from
6789caa to
e181e0c
Compare
The test setup creates an order without any line items but a shipped shipment. This is not possible in real world scenarios and leads to false negatives.
We do not need to visit the "Cart" before we visit the "Customer" tab after removing the country.
Mutating the order on the shipments screen is not a good idea and leads to lots of bugs and confusion by users. Mutating the cart should only be possible on the cart page. This removes lots of old, hard to maintain Javascript as well.
Adding a product from the Cart tab brings the order to `confirm` state instead of `cart`, changing the label in the Payment tab.
spaghetticode
force-pushed
the
no-product-add-at-shipments
branch
from
e181e0c to
fa59e21
Compare
spaghetticode
added a commit
to solidusio-contrib/solidus_shipments_add_product
that referenced
this pull request
Aug 30, 2019
Adding JS code that was removed with solidusio/solidus#3214
spaghetticode
added a commit
to solidusio-contrib/solidus_shipments_add_product
that referenced
this pull request
Aug 30, 2019
Adding JS code that was removed with solidusio/solidus#3214
kennyadsl
reviewed
Aug 30, 2019
| @@ -18,6 +18,8 @@ | |||
| <%= render 'spree/admin/orders/risk_analysis', latest_payment: @order.payments.reorder("created_at DESC").first %> | |||
| <% end %> | |||
|
|
|||
| <div data-hook="add_product_button" /> | |||
There was a problem hiding this comment.
I'd try to use a more generic name since other extensions could use this hook in other ways.
There was a problem hiding this comment.
@kennyadsl makes sense 👍
I changed the name to admin_order_edit_sub_header
spaghetticode
force-pushed
the
no-product-add-at-shipments
branch
from
fa59e21 to
5b8b8fb
Compare
This hook is used by the `solidus_shipments_add_product` extension that brings back the "Add Product" link to the admin order shipments page for stores that need that functionality.
spaghetticode
force-pushed
the
no-product-add-at-shipments
branch
from
5b8b8fb to
b06c385
Compare
kennyadsl
approved these changes
Aug 30, 2019
gmacdougall
approved these changes
Sep 11, 2019
spaghetticode
added a commit
to solidusio-contrib/solidus_shipments_add_product
that referenced
this pull request
Sep 12, 2019
Now that solidusio/solidus#3214 is merged, Solidus branch in the Gemfile must be updated to `master`. Until a new Solidus version will be released, only Solidus `master` supports this extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of the work started by @tvdeyen with #3099.
Please refer to that PR for motivations and previous discussions.
This is the admin Shipment page before the changes, when it's still possible to add a product:
This is the same page after the changes, when adding products is not possible anymore:
Of course products can still be added from the Cart page:
Retrocompatibility
Since some stores may want to keep the removed functionality, the code was extracted to the new Solidus extension solidus_shipments_add_product.
Usage is very simple, just add the extension to the Gemfile and run the installer:
The extension will work only on Solidus versions that include this PR.