A promotion without actions should log errors

[johnny243]

Description

The following PR fixes #2777

When a customer tries to apply a promotion coupon code that has no actions, the following will occur:

• They should get the The coupon code you entered doesn't exist. error message
• A warning is logged mentioning said coupon

Checklist:

• I have followed Pull Request guidelines
• I have added a detailed description into each commit message
• I have updated Guides and README accordingly to this change (if needed)
• I have added tests to cover this change (if needed)

[kennyadsl]

Left some change requests, can you please also rebase and squash commit in a single one with a more descriptive message and description? Thanks for your contribution!

[spaghetticode]

@johnny243 is this PR still WIP?

I am asking because the current implementation does not reflect what you wrote on the issue at #2777 (comment)... curious to know if you're interested in going that way... thank you 😄

[johnny243]

@johnny243 is this PR still WIP?

I am asking because the current implementation does not reflect what you wrote on the issue at #2777 (comment)... curious to know if you're interested in going that way... thank you

@spaghetticode I would like to go that way, but I was waiting on some kind of approval/feedback/ideas to make sure I was implementing something that made sense.

I will get back on this issue today. Thanks for following up!

[aldesantis]

This seems to be similar to #3596.

[seand7565]

Adding more info to this - #2777 initially proposed logging an error (which this PR handles) but it seems the discussion has since been moved elsewhere (for the reason that admin users rarely have access to logs - which makes sense to me).

#3596 handles the issue in line with the new discussion from #2777

[kennyadsl]

Closed with #3749