Correct misspelling in API Documentation for Create Product #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsaupe
approved these changes
Oct 15, 2019
|
@octoxan can you please rebase with master, so we get a green CI? Thank you 🙏 💚 |
houndci-bot
reviewed
Oct 18, 2019
| end | ||
|
|
||
| before do | ||
| stock_location.stock_items.update_all(count_on_hand: 10) |
There was a problem hiding this comment.
Rails/SkipsModelValidations: Avoid using update_all because it skips validations.
|
@spaghetticode done |
|
@octoxan something went wrong with the rebase, your PR has now 23 commits from other people |
|
Ah dang. My bad. I'll try to fix it in the morning. I did a `git checkout
master` then a `git pull` followed by a `git rebase master`. Will try to
fix it somehow. Sorry about that!
…On Sat, Oct 19, 2019, 12:04 PM Andrea Longhi ***@***.***> wrote:
@octoxan <https://github.com/octoxan> something went wrong with the
rebase, your PR has now 23 commits from other people
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3370?email_source=notifications&email_token=ABBN34ZMGIXRTXWUCAAJSR3QPMVX7A5CNFSM4I6VSUF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXU3PY#issuecomment-544165311>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBN345Y5J4LWBGWRAZ5223QPMVX7ANCNFSM4I6VSUFQ>
.
|
|
There we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Creates" in the header was misspelled as "Creaets". This is just a quick fix.
Checklist: