Fixing product discard and classifications issue #3439
Conversation
When removing a product via discard, it was destroying all classifications via delete_all, acts as list callbacks were not called leaving gaps in position.
| @@ -25,7 +25,7 @@ class Product < Spree::Base | |||
| variants_including_master.discard_all | |||
| self.product_option_types = [] | |||
| self.product_properties = [] | |||
| self.classifications = [] | |||
| self.classifications.destroy_all | |||
There was a problem hiding this comment.
Style/RedundantSelf: Redundant self detected.
There was a problem hiding this comment.
Great catch, I think we should use discard_all instead. Also, in another PR I think it's a good idea to do the same with the rest of the associations in that block, if they are soft-deletable, right?
There was a problem hiding this comment.
Classifications is not discard'able, that's why I used destroy_all so act_as_list callbacks are executed.
I also had a look at the other relationships and the only one with callbacks is product properties but position is only used for sorting, it does not affect like in classifications
There was a problem hiding this comment.
You are right @softr8, the rest of associations should be handled in a different context, if needed. Thanks!
| @@ -25,7 +25,7 @@ class Product < Spree::Base | |||
| variants_including_master.discard_all | |||
| self.product_option_types = [] | |||
| self.product_properties = [] | |||
| self.classifications = [] | |||
| self.classifications.destroy_all | |||
There was a problem hiding this comment.
You are right @softr8, the rest of associations should be handled in a different context, if needed. Thanks!
When removing a product via discard, it was destroying all
classifications via delete_all, acts as list callbacks were
not called leaving gaps in position.
Created this one instead of #3172
Checklist: