Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit closing div to admin order edit #3473

Merged
merged 1 commit into from
Jan 10, 2020
Merged

add explicit closing div to admin order edit #3473

merged 1 commit into from
Jan 10, 2020

Conversation

peterberkenbosch
Copy link
Contributor

@peterberkenbosch peterberkenbosch commented Jan 9, 2020 •
edited
Loading

Description
Backend order edit form is not rendering correctly.

Before:
Screenshot 2020-01-09 at 14 58 35
Screenshot 2020-01-09 at 14 57 42

After:

Screenshot 2020-01-09 at 14 58 20

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@peterberkenbosch
add explicit closing div to admin order edit
e28aeea 
With the implicit closing div, the form is not rendering correctly
in Chrome. (have not tested other browsers).

With this commit the layout is correct again.
aldesantis
aldesantis approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@aldesantis aldesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterberkenbosch!

spaghetticode
spaghetticode approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍

@aldesantis aldesantis merged commit 32d4d78 into solidusio:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldesantis aldesantis aldesantis approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterberkenbosch @spaghetticode @aldesantis