Add discontinue on to products #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 8, 2020
core/db/migrate/20201008213609_add_discontinue_on_to_spree_products.rb
Outdated
Show resolved
Hide resolved
spaghetticode
requested changes
Oct 9, 2020
There was a problem hiding this comment.
@tvdeyen thanks for the new feature, it looks good but there's a comment that needs a small change.
|
@kennyadsl @aldesantis there are lots of failing specs that don't seem to be related to this PR. Do I need to do something or do we have CI issues? |
tvdeyen
force-pushed
the
add-discontinue_on-to-products
branch
from
36784ff to
b1421e2
Compare
Products have an available on timestamp, but no discontinue on date. For actual timebased publishing we should have one. The name of the attribute has been chosen to be compatible with stores migrating from Spree >= 3.1
Like with the available on date we want to be able to set the discontinue on date as well.
tvdeyen
force-pushed
the
add-discontinue_on-to-products
branch
from
b1421e2 to
69690e0
Compare
A convenient predicate method to check the discontinued state of a product.
tvdeyen
force-pushed
the
add-discontinue_on-to-products
branch
from
5eb32ec to
d5a7dc4
Compare
jarednorman
approved these changes
Oct 13, 2020
spaghetticode
approved these changes
Oct 13, 2020
|
😍 Thanks @tvdeyen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
discontinue_onattribute to products. This accompanies theavailable_onattribute to complete the "Time Based Availability" feature. TheProduct.availablescope andProduct#avaliable?method take this new date filed into account to calculate the availability of products.Refs #465
Note
Contrary to the suggestions in #465 I used the
discontinue_onattribute introduced in Spree 3.1 for compatibility reasons. If we think this is a mistake we can also rename the attribute, but this will make migrations for former Spree users harder.Checklist: