Remove legacy address state validation logic #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address state validation logic has been extracted into a dedicated class. The legacy validation logic has been kept for compatibility reasons allowing stores to upgrade without being forced to switch to the new validation logic. With this commit the old validation is definitely removed.
cedum
force-pushed
the
remove-legacy-address-validation
branch
from
51940bd to
1e33eb7
Compare
jarednorman
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address state validation logic has been extracted into a dedicated class in #3129
The legacy validation logic has been kept for compatibility reasons allowing stores to upgrade without being forced to switch to the new validation logic.
With this PR, the old validation is definitely removed.
NOTE: this PR is part of a bigger deprecations removal initiative. See PR #3818 for other deprecations being removed.
Removals without deprecation
Spree::Config.use_legacy_address_state_validator: preference introduced for switching between the legacy state validator and the new one. By removing the legacy state validator this preference is no more needed.Checklist: