Adjust CircleCI config to reflect Rails versions that we support #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will save some CI time in preparation of adding Rails 6.0 to the build matrix.
Now that we support Rails 6.1 specs will be run by default on that version. This commit manually adds 6.0 to the matrix to be sure are testing Solidus against that version. We'll only test 6.0 against Postgres to save CI time.
kennyadsl
force-pushed
the
kennyadsl/rails-6.0-specs
branch
from
c8b13d5 to
269bb9f
Compare
The Rails version will be changed by ENV varaibles when needed.
kennyadsl
force-pushed
the
kennyadsl/rails-6.0-specs
branch
from
269bb9f to
355d7fa
Compare
|
The pending CI check should not be expected actually. I removed mysql_rails52 in this PR and I think it's CircleCI not being able to get it. |
jarednorman
approved these changes
Jan 11, 2021
spaghetticode
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently added support for Rails 6.1 but we still need to run specs against Rails 6.0. This PR takes care of that.
To reduce the amount of CI time needed, I decided to remove MySQL tests for older Rails versions.