DRY-up BogusCreditCard model and remove invasive refund spec stub #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Success and failure messages are hardcoded in multiple methods, they can be easily DRYed up by using constants, with the extra benefit that these can be referenced also in subclasses and tests.
Stubs can make tests britte, especially ones that, although presented in a unit test file, are actually integrating the behavior of many classes. Specifically, being this stub defined at the top level, it prevents writing specs that actually want to hit the real implementation of the stubbed method. These seem good enough reasons for removing it.
kennyadsl
approved these changes
Mar 19, 2021
jarednorman
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes 2 commits that were originally proposed with this bugfix that targets v2.11. They're proposed also for the master branch, as they can be beneficial here as well.
Checklist: