Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUID to StoreCredit#generate_authorization_code #4060

Merged
merged 1 commit into from
May 21, 2021
Merged

Add UUID to StoreCredit#generate_authorization_code #4060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/app/models/spree/store_credit.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,12 @@ def can_void?(payment)
end

def generate_authorization_code
"#{id}-SC-#{Time.current.utc.strftime('%Y%m%d%H%M%S%6N')}"
[
id,
'SC',
Time.current.utc.strftime('%Y%m%d%H%M%S%6N'),
SecureRandom.uuid
aldesantis marked this conversation as resolved.
Show resolved Hide resolved
].join('-')
end

def editable?
Expand Down
8 changes: 8 additions & 0 deletions core/spec/models/spree/store_credit_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,4 +897,12 @@
end
end
end

describe "#generate_authorization_code" do
it "doesn't rely on time for uniqueness" do
freeze_time do
expect(subject.generate_authorization_code).not_to eq(subject.generate_authorization_code)
end
end
end
end