Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate callback setting variant price from master #4078

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Deprecate callback setting variant price from master #4078

merged 1 commit into from
Jun 1, 2021

Conversation

waiting-for-dev
Copy link
Contributor

This simplifies logic, and it can be seen as preparatory work to propose
to the user the inheritance of all, and not just the default, prices
from master when creating a new variant.

Extracted from #3994

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

kennyadsl
kennyadsl approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marc!

@kennyadsl
Copy link
Member

Maybe we can add a spec that tests the deprecation warning emitted when the price is not passed?

@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/deprecate_variant_without_price branch 2 times, most recently from efe30ba to 93cf6b4 Compare June 1, 2021 03:22
@waiting-for-dev
Copy link
Contributor Author

Maybe we can add a spec that tests the deprecation warning emitted when the price is not passed?

Makes sense. I added it and rebased from master.

@waiting-for-dev
Deprecate callback setting variant price from master
c8d7868 
This simplifies logic, and it can be seen as preparatory work to propose
to the user the inheritance of all, and not just the default, prices
from master when creating a new variant.
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/deprecate_variant_without_price branch from 93cf6b4 to c8d7868 Compare June 1, 2021 09:34
@kennyadsl kennyadsl merged commit 35d09f3 into solidusio:master Jun 1, 2021
@kennyadsl kennyadsl deleted the waiting-for-dev/deprecate_variant_without_price branch June 1, 2021 11:32
@waiting-for-dev waiting-for-dev mentioned this pull request Jul 14, 2021
Merged
@waiting-for-dev waiting-for-dev mentioned this pull request Aug 9, 2021
Merged
5 tasks
waiting-for-dev added a commit to nebulab/solidus that referenced this pull request Sep 10, 2021
@waiting-for-dev
Prepare CHANGELOG for Solidus 3.1 release
a3703cf 
The new entries have been generated through the following command, as
detailed in the [how-to-release
guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date):

```bash
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus
```

The following items have been removed because of being change/revert
pairs or being changes on top of still-unreleased stuff:

- Docker: Change public keys server after deprecation
  [solidusio#4140](solidusio#4140)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Revert "Deprecate callback setting variant price from master"
  [solidusio#4132](solidusio#4132)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Deprecate callback setting variant price from master
  [solidusio#4078](solidusio#4078)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Remove staled comment
  [solidusio#4100](solidusio#4100)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Disable perform_caching in DummyApp
  [solidusio#4119](solidusio#4119)
  ([gsmendoza](https://github.com/gsmendoza))
- Master now tracks 3.1.0
  [solidusio#4033](solidusio#4033)
  ([kennyadsl](https://github.com/kennyadsl))
kennyadsl pushed a commit that referenced this pull request Sep 10, 2021
@waiting-for-dev
Prepare CHANGELOG for Solidus 3.1 release (#4144)
c6f1d92 
* Prepare CHANGELOG for Solidus 3.1 release

The new entries have been generated through the following command, as
detailed in the [how-to-release
guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date):

```bash
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus
```

The following items have been removed because of being change/revert
pairs or being changes on top of still-unreleased stuff:

- Docker: Change public keys server after deprecation
  [#4140](#4140)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Revert "Deprecate callback setting variant price from master"
  [#4132](#4132)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Deprecate callback setting variant price from master
  [#4078](#4078)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Remove staled comment
  [#4100](#4100)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Disable perform_caching in DummyApp
  [#4119](#4119)
  ([gsmendoza](https://github.com/gsmendoza))
- Master now tracks 3.1.0
  [#4033](#4033)
  ([kennyadsl](https://github.com/kennyadsl))

* Add backported entries
rmparr pushed a commit to rmparr/solidus that referenced this pull request Jun 1, 2022
@waiting-for-dev @rmparr
Prepare CHANGELOG for Solidus 3.1 release (solidusio#4144)
e2d094c 
* Prepare CHANGELOG for Solidus 3.1 release

The new entries have been generated through the following command, as
detailed in the [how-to-release
guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date):

```bash
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus
```

The following items have been removed because of being change/revert
pairs or being changes on top of still-unreleased stuff:

- Docker: Change public keys server after deprecation
  [solidusio#4140](solidusio#4140)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Revert "Deprecate callback setting variant price from master"
  [solidusio#4132](solidusio#4132)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Deprecate callback setting variant price from master
  [solidusio#4078](solidusio#4078)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Remove staled comment
  [solidusio#4100](solidusio#4100)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Disable perform_caching in DummyApp
  [solidusio#4119](solidusio#4119)
  ([gsmendoza](https://github.com/gsmendoza))
- Master now tracks 3.1.0
  [solidusio#4033](solidusio#4033)
  ([kennyadsl](https://github.com/kennyadsl))

* Add backported entries
rmparr pushed a commit to rmparr/solidus that referenced this pull request Jun 1, 2022
@waiting-for-dev @rmparr
Prepare CHANGELOG for Solidus 3.1 release (solidusio#4144)
9476b07 
* Prepare CHANGELOG for Solidus 3.1 release

The new entries have been generated through the following command, as
detailed in the [how-to-release
guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date):

```bash
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus
```

The following items have been removed because of being change/revert
pairs or being changes on top of still-unreleased stuff:

- Docker: Change public keys server after deprecation
  [solidusio#4140](solidusio#4140)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Revert "Deprecate callback setting variant price from master"
  [solidusio#4132](solidusio#4132)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Deprecate callback setting variant price from master
  [solidusio#4078](solidusio#4078)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Remove staled comment
  [solidusio#4100](solidusio#4100)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Disable perform_caching in DummyApp
  [solidusio#4119](solidusio#4119)
  ([gsmendoza](https://github.com/gsmendoza))
- Master now tracks 3.1.0
  [solidusio#4033](solidusio#4033)
  ([kennyadsl](https://github.com/kennyadsl))

* Add backported entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode left review comments

@gmacdougall gmacdougall gmacdougall approved these changes

@mamhoff mamhoff mamhoff approved these changes

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@waiting-for-dev @kennyadsl @spaghetticode @jarednorman @mamhoff @gmacdougall