Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce inverse_of: :product for variants association #4227

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Reintroduce inverse_of: :product for variants association #4227

merged 1 commit into from
Dec 27, 2021

Conversation

spaghetticode
Copy link
Member

@spaghetticode spaghetticode commented Dec 21, 2021 •
edited
Loading

Description

inverse_of: :product was moved to the variants_including_master association with 7c37093, but there should be no problem in having this option specified in more than one association, in fact its removal is causing an issue as now the reference to the product changes is lost for records in the variants association:

p = Spree::Product.first
v = p.variants.first
m = p.variants_including_master.find_by(is_master: true)

p.name = "Foobar"

m.product.name
 # => "Foobar"

v.product.name
# => "Solidus T-Shirt"

Checklist:

@spaghetticode
Reintroduce inverse_of: :product for variants association
3f13f8c 
`inverse_of: :product` was moved to the `variants_including_master`
association with 7c37093, but there shold be no problem in having
this option specified in more than one association, in fact its
removal is causing an issue and now the reference to the product
changes is now  lost for records in the `variants` association:

    p = Spree::Product.first
    v = p.variants.first
    m = p.variants_including_master.find_by(is_master: true)

    p.name = "Foobar"

    m.product.name
     # => "Foobar"

    v.product.name
    # => "Solidus T-Shirt"
@spaghetticode spaghetticode self-assigned this Dec 21, 2021
@spaghetticode spaghetticode marked this pull request as ready for review December 21, 2021 15:12
waiting-for-dev
waiting-for-dev approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't recall anymore why I did that change, but I'd swear it was because of some issue. However, CI is green! I'm ok with merging that and revisiting if we find a problem later on 🙂

jarednorman
jarednorman approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine if it doesn't cause issue. If we find an issue we'll just have to make sure we add a spec for it.

@waiting-for-dev waiting-for-dev merged commit 97d2d7a into solidusio:master Dec 27, 2021
@waiting-for-dev waiting-for-dev deleted the spaghetticode/reintroduce-inverse-of branch December 27, 2021 06:20
This was referenced Jan 3, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees

@spaghetticode spaghetticode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaghetticode @waiting-for-dev @jarednorman