Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributor logo on README.md #4257

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Update contributor logo on README.md #4257

merged 1 commit into from
Feb 7, 2022

Conversation

mfrecchiami
Copy link
Contributor

The Nebulab logo has a white background now, so it is visible also with dark mode enabled.

Description
This is how the logo is displayed with dark-mode enabled:

Screenshot 2022-02-04 at 17 34 03

This is how it is changed:

Screenshot 2022-02-04 at 17 33 53

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • [] I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@mfrecchiami
Update contributor logo on README.md
98b3090 
The Nebulab logo has a white background now, so it is visible also with dark mode enabled.
jarednorman
jarednorman approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, reminds me that we need to update ours here too! That's the logo I made before we had real designers do our branding. 😅

waiting-for-dev
waiting-for-dev approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mfrecchiami!!!

@waiting-for-dev waiting-for-dev merged commit a7c21ad into solidusio:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfrecchiami @waiting-for-dev @jarednorman